Updated SNS hello-world code example #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
approved these changes
Jun 18, 2021
| use std::process::exit; | ||
|
|
||
| use aws_types::region::ProvideRegion; |
There was a problem hiding this comment.
More of a question for @rcoh than a blocker on this PR: should we be re-exporting ProvideRegion in each individual SDK so that explicit dependencies on aws-types aren't necessary?
There was a problem hiding this comment.
yeah we should have a quick design discussion about this (common?) use case of setting of a region chain. We can export as long as we aren't worried about it being an anti-pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The example had a hard-coded, bogus, email address.
Description of changes:
You now specify an email address with -e EMAIL_ADDRESS.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.