Add benchmark for DynamoDB serialization/deserialization #507
Conversation
There was a problem hiding this comment.
not sure if intentionally or unintentionally, you're actually testing a lot more than just the serializers. If you just want to benchmark the serializer, I would write something much closer to what the protocol tests generate and use make_operation and ParseResponse directly. (Note that in the case of dynamo, you can use ParseStrictResponse since none of the responses are streaming)
|
Definitely was unintentionally testing more than I wanted to, but I wasn't aware of how to do the parsing directly. Thanks for the pointers! I updated the PR with a much nicer implementation that should give us better information. |
| use smithy_http::response::ParseHttpResponse; | ||
| use tokio::runtime::Builder as RuntimeBuilder; | ||
|
|
||
| async fn do_bench() { |
There was a problem hiding this comment.
This function actually doesn't need to be async
| }; | ||
| } | ||
|
|
||
| async fn do_bench(config: &Config, input: &PutItemInput) { |
There was a problem hiding this comment.
This also doesn't need to be async anymore
| @@ -240,7 +245,7 @@ tasks.register<Exec>("cargoCheck") { | |||
| workingDir(sdkOutputDir) | |||
| // disallow warnings | |||
| environment("RUSTFLAGS", "-D warnings") | |||
| commandLine("cargo", "check") | |||
| commandLine("cargo", "check", "--lib", "--tests", "--benches") | |||
There was a problem hiding this comment.
Since CI doesn't actually hit this, we should also update the CI job
More work towards #161. This adds a benchmark for JSON serialization/deserialization for real-world DynamoDB calls.
Sample output:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.