Introduce generic fluent client generator to non-sdk codegen — take 2 #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 3, 2021 10:19
Since the function "doesn't exist", we can't link to it. Arguably, the docs should only be tested with all features enabled, but for now just don't try to link to `native_tls`.
added 8 commits
June 7, 2021 16:12
The standard syntax doesn't work: rust-lang/rust#86120
With the extra "helpful" bound, we also end up enforcing that C
implements Service, but since we're in a builder, C may not have been
set yet, and may be (), which in turn means that it isn't Service. So
users would end up with an error if they write:
Builder::new().middleware_fn(|r| r).https().build()
but it would work with
Builder::new().https().middleware_fn(|r| r).build()
which is silly.
rcoh
approved these changes
Jun 11, 2021
jonhoo
commented
Jul 6, 2021
| #[doc(inline)] | ||
| /// AWS Service Client builder. | ||
| /// | ||
| /// See [`smithy_client::Builder`] for details. |
There was a problem hiding this comment.
These type aliases can both be #[doc(inline)] again once rust-lang/rust#86120 hits stable (or subject to the MSRV policy). @rcoh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #463 again, but with a fix for the infinite recursion that triggered #493, and a change to address the fact that
#[doc(inline)]isn't allowed for type aliases.