Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trivial mistake in error message. #3952

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

deven
Copy link
Contributor

@deven deven commented Dec 28, 2024

Motivation and Context

This commit fixes a bad error message.

Description

In read_profile_line(), when .strip_prefix('[') fails, the original error message was Profile definition must start with ], which is obviously wrong. This commit fixes the error message to be Profile definition must start with '[', which corrects the mistake in the original error message (fixing ] to be [), and adds the single quotes to match the formatting of the error message used when .strip_suffix(']') fails (Profile definition must end with ']').

Testing

No testing is needed here; this is solely a change to a hardcoded error message string.

Checklist

This is a trivial fix. Is it really interesting enough to mention in a changelog?

  • For changes to the smithy-rs codegen or runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "client," "server," or both in the applies_to key.
  • For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the .changelog directory, specifying "aws-sdk-rust" in the applies_to key.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@deven deven requested a review from a team as a code owner December 28, 2024 04:08
@landonxjames
Copy link
Contributor

@landonxjames
Copy link
Contributor

Canary and CI check succeeded, thanks for the contribution! Merging

@deven
Copy link
Contributor Author

deven commented Dec 28, 2024

@landonxjames Looks like the merge stalled?

@landonxjames landonxjames added this pull request to the merge queue Dec 28, 2024
@landonxjames
Copy link
Contributor

Oops, no it was late and I forgot to actually approve the change. Should go through now.

Merged via the queue into smithy-lang:main with commit 6cc3ed7 Dec 28, 2024
40 of 42 checks passed
@deven deven deleted the fix-error-message branch December 28, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants