Set MSRV in rust-toolchain.toml using the gradle.property #3841
+131
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Sep 19, 2024
drganjoo
force-pushed
the
fahadzub/override
branch
from
e60f33a
to
e84cc62
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/override
branch
from
e84cc62
to
3afa923
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/override
branch
from
32de322
to
c3e337f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rust-toolchain.tomlfile for tests now uses therust.msrvvalue from thegradle.propertiesfile.This PR also fixes an issue where the
rust-toolchain.tomlfile was not created in the overridden test directory whenoverrideTestDirwas set. This caused the installed compiler version to be used, resulting in errors with the latest compiler and preventing the use ofoverrideTestDir.Closes: #2048