Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfiles #3821

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Update lockfiles #3821

merged 3 commits into from
Sep 6, 2024

Conversation

ysaito1001
Copy link
Contributor

@ysaito1001 ysaito1001 commented Sep 6, 2024

Description

This PR updates lockfiles by running:

./gradlew aws:sdk:generateAllLockfiles -Paws-sdk-rust-path=/Users/awsaito/src/aws-sdk-rust

However, due to the minicbor issue, we still pin it to 0.24.2 by running the following on rust-runtime/Cargo.lock and aws/sdk/Cargo.lock:

RUSTFLAGS="--cfg aws_sdk_unstable" cargo update -p minicbor --precise 0.24.2

The rest of the changes handle miscellaneous scenarios:

  • Updated nightly version: Upgraded to nightly-2024-03-15 to address a compatibility issue introduced by the updated serde library.
  • Cleaned up use statements: Removed redundant use statements, which were flagged as warnings by the new nightly version.

Testing

Tests in CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Sep 6, 2024

A new generated diff is ready to view.

A new doc preview is ready to view.

@ysaito1001 ysaito1001 marked this pull request as ready for review September 6, 2024 15:26
@ysaito1001 ysaito1001 requested review from a team as code owners September 6, 2024 15:26
@ysaito1001 ysaito1001 added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@ysaito1001 ysaito1001 added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 064fbd7 Sep 6, 2024
44 checks passed
@ysaito1001 ysaito1001 deleted the ysaito/update-lockfiles branch September 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants