Make when expression non exhaustive in EndpointBuiltInsDecorator.kt #3634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Updates handling matching on endpoint parameter type in
EndpointBuiltInsDecorator.kt
Description
Smithy 1.48.0 will introduce
ParameterType.STRING_ARRAY
for the endpoint parameter type and exhaustive matching like what we have today makes lint unhappy.For now, we will fail out loud for anything other than
string
orboolean
since we most likely don't have services that supportParameterType.STRING_ARRAY
today. The panic will let us know during internal preview when a service supportsParameterType.STRING_ARRAY
.Testing
Relies on tests in CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.