Http Protocol Refactor & Streaming Request bodies (breaking change) #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
May 11, 2021
rcoh
changed the title
rcoh
added a commit
that referenced
this pull request
May 12, 2021
…359) * Refactor HttpProtocolGenerator body construction * Well that was easy... (add streaming input support) * Fix tests, clippy warning * One more clippy wrap ignore * Fix test that used private API * Add test for default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #215
Description of changes: This change, split into two commits:
These refactors (besides cleaning up the code) improve the performance of serializers by avoiding an unnecessary when serializing
Blob&ByteStreamoperations. This is facilitated viaBodyMetadatawhich allows a body serializer to communicate whether it requires ownership of the request object.In general, we try to generate operations that do not take ownership of the request object enabling operation reuse.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.