Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy 1.7 upgrade #340

Merged
merged 7 commits into from
Apr 29, 2021
Merged

Smithy 1.7 upgrade #340

merged 7 commits into from
Apr 29, 2021

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented Apr 28, 2021

Issue #, if available: Fixes #334
Description of changes: Upgrade to Smithy 1.7

  1. Add support for shape renaming. Since renaming doesn't apply to operations, errors, or resources, this was actually a fairly narrow change. I intentionally
    maintained the ability to generate a model without a service shape, I expect at some point, some one will just want to make some Rust structs.
  2. Add support for map-driven query params.

The second commit pulls in the latest APIGW model which actually utilizes the httpQueryParams trait.

Generated code diff: main-generated...smithy-17-upgrade-generated

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rcoh added 2 commits April 28, 2021 10:03
Two changes:
1. Add support for shape renaming. Since renaming doesn't apply to operations, errors, or resources, this was actually a fairly narrow change. I intentionally
maintained the ability to generate a model without a service shape, I expect at some point, some one will just want to make some Rust structs.
2. Add support for map-driven query params.
@rcoh rcoh requested a review from a team April 28, 2021 14:18
Copy link

@wooj2 wooj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rcoh rcoh merged commit 0bef36c into main Apr 29, 2021
@rcoh rcoh deleted the smithy-17-upgrade branch April 29, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smithy 1.7 upgrade
2 participants