Allow injecting methods with generic type parameters in the config object #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject This is a follow-up to #3111. Currently, the injected methods are limited to taking in concrete types. This PR allows for these methods to take in generic type parameters as well. ```rust impl<L, H, M> SimpleServiceConfigBuilder<L, H, M> { pub fn aws_auth<C>(config: C) { ... } } ```
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
reviewed
Dec 1, 2023
...otlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServiceConfigGenerator.kt
Show resolved
Hide resolved
...otlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServiceConfigGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServiceConfigGenerator.kt
Show resolved
Hide resolved
...n/software/amazon/smithy/rust/codegen/server/smithy/generators/ServiceConfigGeneratorTest.kt
Outdated
Show resolved
Hide resolved
82marbag
approved these changes
Dec 14, 2023
…ams-in-methods-injected-in-config
drganjoo
approved these changes
Dec 19, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
deleted the
davidpz/generic-params-in-methods-injected-in-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3111. Currently, the injected methods are
limited to taking in concrete types. This PR allows for these methods to
take in generic type parameters as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.