Lifetimes in builders #3249
Merged
Lifetimes in builders #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Nov 23, 2023
...main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/StructureGenerator.kt
Outdated
Show resolved
Hide resolved
...otlin/software/amazon/smithy/rust/codegen/server/smithy/generators/ServerBuilderGenerator.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
pushed a commit
that referenced
this pull request
Nov 27, 2023
## Motivation and Context We're not handling lifetimes in builders of structures. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
ysaito1001
pushed a commit
that referenced
this pull request
Nov 28, 2023
## Motivation and Context We're not handling lifetimes in builders of structures. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
## Description Lifetimes in `TryFrom`, see: #3249 ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
rcoh
pushed a commit
that referenced
this pull request
Dec 14, 2023
## Description Lifetimes in `TryFrom`, see: #3249 ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We're not handling lifetimes in builders of structures.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.