Small tweaks to the HTTP wrapper #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Oct 26, 2023
| @@ -132,7 +132,7 @@ fn apply_endpoint( | |||
| for (header_name, header_values) in endpoint.headers() { | |||
| request.headers_mut().remove(header_name); | |||
| for value in header_values { | |||
| request.headers_mut().insert( | |||
| request.headers_mut().append( | |||
There was a problem hiding this comment.
would be nice to have a unit test for the use of append if we don't have one.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Oct 27, 2023
| @@ -404,8 +404,10 @@ impl Headers { | |||
| /// Removes all headers with a given key | |||
| /// | |||
| /// If there are multiple entries for this key, the first entry is returned | |||
There was a problem hiding this comment.
Should we be more explicit and add something like "all other entries are discarded" or "to get all values for a given key, keep calling this until it returns None"?
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
.insertwas called but it should have beenappendBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.