Move default endpoint resolver into a runtime plugin #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
changed the title
rcoh
force-pushed
the
endpoints-refactor-part1
branch
from
e228acc to
149fc7a
Compare
jdisanti
approved these changes
Oct 16, 2023
ysaito1001
approved these changes
Oct 16, 2023
rcoh
force-pushed
the
endpoints-refactor-part1
branch
from
c0b5d7e to
88718ee
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
force-pushed
the
endpoints-refactor-part1
branch
from
88718ee to
92b0c9f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Oct 17, 2023
| fun addServiceRuntimePlugin(writer: RustWriter, plugin: Writable) { | ||
| writer.rustTemplate(".with_service_plugin(#{plugin})", "plugin" to plugin) | ||
| fun addClientPlugin(writer: RustWriter, plugin: Writable) { | ||
| writer.rustTemplate(".with_client_plugin(#{plugin})", "plugin" to plugin) | ||
| } | ||
|
|
||
| fun addOperationRuntimePlugin(writer: RustWriter, plugin: Writable) { |
There was a problem hiding this comment.
Nit: rename this to be consistent with the client level function
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit also refactors idempotency tokens to be centralized in a decorator
rcoh
force-pushed
the
endpoints-refactor-part1
branch
from
61194a5 to
60e4ee8
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
…-specific trait (#3078) ## Motivation and Context - Fixes #3043 As a follow up to #3072 this removes the old endpoint resolver interfaces in favor of creating a per-service resolver trait. This trait defines a `into_shared_resolver()` method which converts the local trait into a global resolver that can be used with the orchestrator. ## Description <!--- Describe your changes in detail --> ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
rcoh
added a commit
that referenced
this pull request
Oct 19, 2023
…-specific trait (#3078) ## Motivation and Context - Fixes #3043 As a follow up to #3072 this removes the old endpoint resolver interfaces in favor of creating a per-service resolver trait. This trait defines a `into_shared_resolver()` method which converts the local trait into a global resolver that can be used with the orchestrator. ## Description <!--- Describe your changes in detail --> ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Checklist <!--- If a checkbox below is not applicable, then please DELETE it rather than leaving it unchecked --> - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates - [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In preparation for inlining the old endpoint traits, I'm cleaning up the endpoint resolver behavior.
Description
Configfield ofservice_runtime_pluginwas unused to I deleted itRuntimeComponentsinstead of in operation config. This allows a lot of complex logic aroundConfigOverrideto be removed.EndpointResolver, allow final construction ofRuntimeComponentsto failServiceRuntimePluginhas been changed toDefaultsso that it doesn't overwrite settings set by the service configTesting
Well covered by existing UT / IT
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.