Fix: orchestrator flow #2699
Merged
Fix: orchestrator flow #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still have some rough edges to sand off, but the interceptor tests are passing. |
|
|
jdisanti
reviewed
May 13, 2023
rust-runtime/aws-smithy-runtime-api/src/client/interceptors/context/wrappers.rs
Outdated
Show resolved
Hide resolved
update: interceptor tests to work with the new wrappers.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
May 16, 2023
aws/sra-test/integration-tests/aws-sdk-s3/tests/interceptors.rs
Outdated
Show resolved
Hide resolved
rust-runtime/aws-smithy-runtime-api/src/client/interceptors/context.rs
Outdated
Show resolved
Hide resolved
rust-runtime/aws-smithy-runtime-api/src/client/interceptors/context.rs
Outdated
Show resolved
Hide resolved
rust-runtime/aws-smithy-runtime-api/src/client/interceptors/context/wrappers.rs
Show resolved
Hide resolved
| @@ -61,6 +62,11 @@ impl InterceptorError { | |||
| interceptor_error_fn!(modify_before_completion => ModifyBeforeCompletion (with source)); | |||
| interceptor_error_fn!(read_after_execution => ReadAfterExecution (with source)); | |||
|
|
|||
| interceptor_error_fn!(modify_before_attempt_completion_failed => ModifyBeforeAttemptCompletion (with source)); | |||
There was a problem hiding this comment.
Yes, because even though an error in these interceptors won't cause us to return, we still need to record that an interceptor failed.
rust-runtime/aws-smithy-runtime-api/src/client/interceptors/error.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
remove: `impl From<InterceptorError> for TypeErasedError` formatting: update the `halt_on_err` macro to fmt nicely
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
May 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
pushed a commit
that referenced
this pull request
May 19, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Necessary before we can implement retries. ## Description <!--- Describe your changes in detail --> I noticed that we weren't handling the flow quite right when errors occurred. This PR fixes that and adds interceptor-based tests to ensure things are working right. I still think we could use more tests but the PR is already quite large. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> This PR contains tests ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Necessary before we can implement retries. ## Description <!--- Describe your changes in detail --> I noticed that we weren't handling the flow quite right when errors occurred. This PR fixes that and adds interceptor-based tests to ensure things are working right. I still think we could use more tests but the PR is already quite large. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> This PR contains tests ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Necessary before we can implement retries. ## Description <!--- Describe your changes in detail --> I noticed that we weren't handling the flow quite right when errors occurred. This PR fixes that and adds interceptor-based tests to ensure things are working right. I still think we could use more tests but the PR is already quite large. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> This PR contains tests ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Necessary before we can implement retries.
Description
I noticed that we weren't handling the flow quite right when errors occurred. This PR fixes that and adds interceptor-based tests to ensure things are working right. I still think we could use more tests but the PR is already quite large.
Testing
This PR contains tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.