Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for configuring interceptors on generic client #2697

Merged
merged 28 commits into from
May 12, 2023
Merged

Allow for configuring interceptors on generic client #2697

merged 28 commits into from
May 12, 2023

Commits on May 3, 2023

  1. Add newtypes for a shared interceptor and its collection 

    This commit adds newtypes `SharedInterceptor` and `AddOnlyInterceptors`
around existing types so that they can be used outside of their defining
crates without revealing the implementation details.
    @ysaito1001
    ysaito1001 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9d0e481 View commit details
    Browse the repository at this point in the history

  2. Configure interceptors in ConfigLoader and SdkConfig 

    This commit allows users to pass their own interceptors to
`ConfigLoader` and to `SdkConfig`. The docs for their methods are marked
as `#[doc(hidden)]` until the orchestrator is fully functional.
    @ysaito1001
    ysaito1001 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    97f0f0c View commit details
    Browse the repository at this point in the history

  3. Generate code for registering user interceptors 

    This commit updates the codegen to register user-passed-in interceptors.
Registration takes place at the client config level and the operation
config level. The former is handled in `ServiceRuntimePlugin` and the
latter in service config `Builder`.
    @ysaito1001
    ysaito1001 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d9d93fe View commit details
    Browse the repository at this point in the history

  4. Add tests to verify configuring interceptors 

    This commit updates `sra_test` to verify interceptors can be configured
at the client config level. It also adds a test to ensure interceptors
registered run according to the pre-defined priority.
    @ysaito1001
    ysaito1001 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    85c313a View commit details
    Browse the repository at this point in the history

  5. Address test failures in CI

    @ysaito1001
    ysaito1001 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    fb62dd3 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Merge branch 'main' into ysaito/configure-interceptors-at-various-levels

    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    b4d9054 View commit details
    Browse the repository at this point in the history

  2. Update aws/rust-runtime/aws-config/src/lib.rs 

    Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    ac1c69c View commit details
    Browse the repository at this point in the history

  3. Update aws/rust-runtime/aws-config/src/lib.rs 

    Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    4d3d390 View commit details
    Browse the repository at this point in the history

  4. Update aws/rust-runtime/aws-config/src/lib.rs 

    Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    462a355 View commit details
    Browse the repository at this point in the history

  5. Update codegen-client/src/main/kotlin/software/amazon/smithy/rust/cod… 

    …egen/client/smithy/customizations/InterceptorConfigCustomization.kt

Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    f011bd9 View commit details
    Browse the repository at this point in the history

  6. Update codegen-client/src/main/kotlin/software/amazon/smithy/rust/cod… 

    …egen/client/smithy/customizations/InterceptorConfigCustomization.kt

Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    1baba61 View commit details
    Browse the repository at this point in the history

  7. Update codegen-client/src/main/kotlin/software/amazon/smithy/rust/cod… 

    …egen/client/smithy/generators/config/ServiceConfigGenerator.kt

Co-authored-by: John DiSanti <jdisanti@amazon.com>
    @ysaito1001 @jdisanti
    ysaito1001 and jdisanti authored May 5, 2023
    Configuration menu
    Copy the full SHA
    2c9167d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'ysaito/configure-interceptors-at-various-levels' of htt… 

    …ps://github.com/awslabs/smithy-rs into ysaito/configure-interceptors-at-various-levels
    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c68c761 View commit details
    Browse the repository at this point in the history

  9. Make the getter interceptors #[doc(hidden)] 

    This commit addresses #2669 (comment)
    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    32f7334 View commit details
    Browse the repository at this point in the history

  10. Drop # from #[doc(hidden)] in comments for codegen

    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    da7a306 View commit details
    Browse the repository at this point in the history

  11. Rename AddOnlyInterceptors to InterceptorRegistrar 

    This commit addresses #2669 (comment)
    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    8c1fc01 View commit details
    Browse the repository at this point in the history

  12. Rename set_interceptor and add set_interceptors 

    This commit addresses the following discussions:
#2669 (comment)
#2669 (comment)
    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ba26b98 View commit details
    Browse the repository at this point in the history

  13. Replace doc example with one modifying request URI 

    This commit addresses the following discussions:
#2669 (comment)
#2669 (comment)
    @ysaito1001
    ysaito1001 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    5583680 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Fix clippy warning needless_borrow

    @ysaito1001
    ysaito1001 committed May 6, 2023
    Configuration menu
    Copy the full SHA
    02cdf15 View commit details
    Browse the repository at this point in the history

  2. Add SharedInterceptor to approved types in aws-types

    @ysaito1001
    ysaito1001 committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e8df08b View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Exclude aws runtime crates from interceptor config 

    This commit addresses #2669 (comment)
    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1d834d0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ysaito/configure-interceptors-on-generic-client

    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9618366 View commit details
    Browse the repository at this point in the history

  3. Replace Interceptors with InterceptorRegistrar in test

    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bbc3dab View commit details
    Browse the repository at this point in the history

  4. Change what to say in .expect 

    This commit addresses #2697 (comment)
    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    44af0db View commit details
    Browse the repository at this point in the history

  5. Remove #[allow(dead_code)] that should be unnecessary 

    This commit addresses #2697 (comment)
    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    73c3515 View commit details
    Browse the repository at this point in the history

  6. Update codegen variable name for InterceptorRegistrar 

    This commit addresses #2697 (comment)
    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    24e176d View commit details
    Browse the repository at this point in the history

  7. Add the extend method to InterceptorRegistrar 

    This commit incorporates feedback #2697 (comment)
    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    9205f49 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into ysaito/configure-interceptors-on-generic-client

    @ysaito1001
    ysaito1001 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3fff36b View commit details
    Browse the repository at this point in the history