add: request information header interceptors and plugins #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Apr 26, 2023
rust-runtime/aws-smithy-runtime/src/client/orchestrator/interceptors/service_clock_skew.rs
Outdated
Show resolved
Hide resolved
rust-runtime/aws-smithy-runtime/src/client/orchestrator/interceptors/service_clock_skew.rs
Outdated
Show resolved
Hide resolved
|
|
||
| fn build_ttl_pair(&self, cfg: &ConfigBag) -> Option<(Cow<'static, str>, Cow<'static, str>)> { | ||
| let timeout_config = cfg.get::<TimeoutConfig>()?; | ||
| let socket_read = timeout_config.read_timeout()?; |
There was a problem hiding this comment.
Is this right? Seems like it needs to factor in multiple possible timeouts.
There was a problem hiding this comment.
The internal-only spec for this specifies the calculation this way.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Apr 27, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
This is currently blocked on fixing how the orchestrator retries are triggered. |
|
This PR fell through the cracks. It's ready to be merged, so I've put it in the queue. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
pushed a commit
that referenced
this pull request
May 18, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> #1793 ## Description <!--- Describe your changes in detail --> This adds a runtime plugin which provides support for a request info header. The plugin depends upon three interceptors: - `ServiceClockSkewInterceptor` - tracks the approximate latency between the client and server - `RequestAttemptsInterceptor` - tracks the number of attempts made for a single operation - `RequestInfoInterceptor` - adds request metadata to outgoing requests. Works by setting a header. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I wrote one test but need to implement several more ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> #1793 ## Description <!--- Describe your changes in detail --> This adds a runtime plugin which provides support for a request info header. The plugin depends upon three interceptors: - `ServiceClockSkewInterceptor` - tracks the approximate latency between the client and server - `RequestAttemptsInterceptor` - tracks the number of attempts made for a single operation - `RequestInfoInterceptor` - adds request metadata to outgoing requests. Works by setting a header. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I wrote one test but need to implement several more ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
david-perez
pushed a commit
that referenced
this pull request
May 22, 2023
## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> #1793 ## Description <!--- Describe your changes in detail --> This adds a runtime plugin which provides support for a request info header. The plugin depends upon three interceptors: - `ServiceClockSkewInterceptor` - tracks the approximate latency between the client and server - `RequestAttemptsInterceptor` - tracks the number of attempts made for a single operation - `RequestInfoInterceptor` - adds request metadata to outgoing requests. Works by setting a header. ## Testing <!--- Please describe in detail how you tested your changes --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> I wrote one test but need to implement several more ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1793
Description
This adds a runtime plugin which provides support for a request info header.
The plugin depends upon three interceptors:
ServiceClockSkewInterceptor- tracks the approximate latency between the client and serverRequestAttemptsInterceptor- tracks the number of attempts made for a single operationRequestInfoInterceptor- adds request metadata to outgoing requests. Works by setting a header.Testing
I wrote one test but need to implement several more
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.