Cleanup module handling & add support for Cargo features #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kggilmer
approved these changes
Mar 16, 2021
| writer.raw("#[") | ||
| writer.writeInline(annot) | ||
| writer.write("]") | ||
| data class Cfg(val cond: String) : Attribute() { |
There was a problem hiding this comment.
need a raise so I can buy some
There was a problem hiding this comment.
nah just joking, but the thing in rust is cfg so I figured I'd just name it the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes a number of small issues around cargo crate management:
injectInlineDependenciesnow iterates until a fixed point is reached (allowing inline dependencies to depend on other inline dependencies)RustCratewrapper aroundCodegenWriterDelegatorto track module metadataAttributesvariants into theAttributesclass to clarify usageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.