-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client
to codegen-client
package namespace
#1711
Conversation
A new generated diff is ready to view.
A new doc preview is ready to view. |
Perhaps we should ignore this commit in blame? https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view |
Are we settling then on the convention that the namespace containing |
I like this idea! Looks like I'll have to do this after merging this since the final squashed commit hash isn't known yet.
I wasn't intending to establish anything one way or another here, but I think this should be fine if you want to do it. The only downside is that it will be harder to find the class you want in an IDE when searching by name since you'll have multiple to choose from. I'm hoping we'll have less name collisions as we refactor away from an inheritance approach to a composition approach. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
I didn't want to include this in #1697 since it would make that diff a lot larger and more difficult to merge in. This adds
client
to the package names in thecodegen-client
module.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.