Fixes for RustWriter bugs #1465 & #1459 #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velfi
approved these changes
Jun 15, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
oh hmm...looking at the generated code diff, this adds extra newlines |
crisidev
reviewed
Jun 15, 2022
| @@ -259,6 +260,9 @@ fun <T : AbstractCodeWriter<T>> T.docs(text: String, vararg args: Any, newlinePr | |||
| // Rustdoc warns on tabs in documentation | |||
| it.trimStart().replace("\t", " ") | |||
| } | |||
| // Because writing docs relies on the newline prefix, ensure that there was a new line written | |||
| // before we write the docs | |||
| this.ensureNewline() | |||
There was a problem hiding this comment.
I was looking into this from a completely wrong angle..
crisidev
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Attribute.Custom.render()is stripping comment line chars//#1465Description
Fix for two longstanding RustWriter bugs:
docsdidn't callensureNewLine()which meant that when it was invoked after a call towriteInlinethe leading///was never written:Wdidn't go through template rewriting which meant that it didn't work with case sensitivity.This resolves both of those issues and adds unit tests.
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.