Non-functional miscellaneous improvements #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it consistent with the `ServerBuilderGenerator` from #1342.
I keep rereading the implementation to see what this returns; it's not intuitive from the function name.
Merged
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
rcoh
approved these changes
Jun 9, 2022
| @@ -293,7 +296,7 @@ class SymbolVisitor( | |||
| return symbolBuilder( | |||
| shape, | |||
| RustType.Opaque( | |||
| shape.contextName() | |||
There was a problem hiding this comment.
this is fine—operations can't be renamed which is why the no-arg method exists
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains non-functional (i.e. mostly stylistic, small
refactors, documentation and consistency) improvements that I've batched
and rolled up while working on #1342.
extraDependenciesfromInlineDependencyclass privateRustTypes.ktRuntimeTypes.ktRuntimeTypes.ktSymbolVisitor.ktBuilderGenerator.ktServerBuilderGeneratorfrom Builders of builders #1342.TestHelpers.ktheaders_for_prefixfunctionnot intuitive from the function name.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.