Overhaul stalled stream protection and add upload support #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
Results of running the stalled stream protection performance test in release mode. These numbers are across six separate runs of the performance test each, averaged, and with a standard deviation applied. The performance is roughly the same, with maybe a miniscule amount of improvement. The new implementation uses 80 bytes of memory for the log instead of 1 kilobyte though. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/throughput.rs
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Mar 14, 2024
Velfi
approved these changes
Mar 14, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
commented
Mar 19, 2024
rust-runtime/aws-smithy-runtime/src/client/http/body/minimum_throughput/http_body_0_4_x.rs
Show resolved
Hide resolved
jdisanti
force-pushed
the
jdisanti-upload-min-throughput
branch
from
017835c
to
0f1e009
Compare
4 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Mar 27, 2024
rust-runtime/aws-smithy-runtime/src/test_util/capture_test_logs.rs
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
added a commit
that referenced
this pull request
Mar 28, 2024
)" This reverts commit 27834ae.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
)" (#3534) The stalled stream protection changes are triggering a semver hazard that will break the release. Need to revert it temporarily to fix this issue. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 30, 2024
Merging #3485 uncovered a semver hazard in the S3 stalled stream protection test due to a subtle (but intentional) change in grace period behavior for stalled streams. That semver hazard was going to cause the SDK release to fail, so #3485 was reverted, and this PR modifies the test so that it will pass with both versions of stalled stream protection as a temporary measure. Once this PR is merged and released, then the new stalled stream protection can be merged again. I tested this by updating the runtime-versioner in #3540 so that I could patch the currently released SDK with these test changes in place, with a local copy of smithy-rs that has the new stalled stream protection implementation. I ran all the tests across all the services in this configuration to verify this was the only hazard that will be hit. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
jdisanti
added a commit
that referenced
this pull request
Apr 3, 2024
This commit unreverts 27834ae (#3485). Original commit message: Overhaul stalled stream protection and add upload support (#3485) This PR overhauls the existing stalled stream protection with a new algorithm, and also adds support for minimum throughput on upload streams. The new algorithm adds support for differentiating between the user or the server causing the stall, and not timing out if it's the user causing the stall. This will fix timeout issues when a customer makes remote service calls in between streaming pieces of information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the existing stalled stream protection with a new algorithm, and also adds support for minimum throughput on upload streams. The new algorithm adds support for differentiating between the user or the server causing the stall, and not timing out if it's the user causing the stall. This will fix timeout issues when a customer makes remote service calls in between streaming pieces of information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.