Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for server event streams #1157

Closed
david-perez opened this issue Feb 4, 2022 · 0 comments · Fixed by #1479
Closed

Add support for server event streams #1157

david-perez opened this issue Feb 4, 2022 · 0 comments · Fixed by #1479
Assignees
@82marbag
Labels
server Rust server SDK

Comments

@david-perez
Copy link
Contributor

david-perez commented Feb 4, 2022 •
edited
Loading

The server SDK supports blob streaming, but we haven't formally added support nor tested event streams https://awslabs.github.io/smithy/1.0/spec/core/stream-traits.html#event-streams
@david-perez david-perez added the server Rust server SDK label Feb 4, 2022
@82marbag 82marbag self-assigned this May 25, 2022
82marbag added a commit that referenced this issue Jun 21, 2022
@82marbag
support server event streams
92e95f4 
* Server event streams
* Rename EventStreamInput to EventStreamSender
* Make event stream errors optional
* Pokemon service model updated
* Pokemon server event handler
* Pokemon client to test event streams
* EventStreamDecorator to make optional using SigV4 signing

Closes: #1157

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
82marbag added a commit that referenced this issue Jun 21, 2022
@82marbag
Support server event streams
c4f1809 
* Server event streams
* Rename EventStreamInput to EventStreamSender
* Make event stream errors optional
* Pokemon service model updated
* Pokemon server event handler
* Pokemon client to test event streams
* EventStreamDecorator to make optional using SigV4 signing

Closes: #1157

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
@82marbag 82marbag mentioned this issue Jun 21, 2022
Merged
2 tasks
82marbag added a commit that referenced this issue Jul 14, 2022
@82marbag
Support server event streams
7ec3c9c 
* Server event streams
* Rename EventStreamInput to EventStreamSender
* Make event stream errors optional
* Pokemon service model updated
* Pokemon server event handler
* Pokemon client to test event streams
* EventStreamDecorator to make optional using SigV4 signing

Closes: #1157

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
82marbag added a commit that referenced this issue Jul 25, 2022
@82marbag @jdisanti
Support server event streams (#1479)
3610085 
* Support server event streams
* Rename EventStreamInput to EventStreamSender
* Custom event stream errors
* EventStreamSender and Receiver are parametrized also on event stream error types
* Pokemon service model updated
* Pokemon server event handler
* Pokemon client to test event streams
* EventStreamDecorator to make optional using SigV4 signing
* Use forInlineFun for all errors

Closes: #1157

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

Co-authored-by: John DiSanti <jdisanti@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@82marbag 82marbag

Labels
server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support server event streams smithy-lang/smithy-rs
2 participants
@david-perez @82marbag