Skip to content

Commit

Permalink
Revert "Allow downgrading smithy-rs versions (#3316)"
Browse files Browse the repository at this point in the history
This reverts commit 5a0e434.
  • Loading branch information
ysaito1001 committed Dec 15, 2023
1 parent fe9f492 commit ef1e37d
Showing 1 changed file with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
*/

use crate::fs::Fs;
use anyhow::{anyhow, Context};
use anyhow::{anyhow, bail, Context};
use clap::Parser;
use once_cell::sync::Lazy;
use regex::Regex;
use smithy_rs_tool_common::package::PackageStability;
use std::borrow::Cow;
use std::path::{Path, PathBuf};
use tracing::warn;

static STABLE_VERSION_REGEX: Lazy<Regex> = Lazy::new(|| {
Regex::new(
Expand Down Expand Up @@ -105,8 +104,7 @@ fn update_gradle_properties<'a>(
// Special version tag used on the `main` branch
&& current_version != semver::Version::parse("0.0.0-smithy-rs-head").unwrap()
{
// NOTE: do not backport this change to mainline during merge.
warn!("Moving from {current_version} to {upgraded_version} is a *downgrade*.");
bail!("Moving from {current_version} to {upgraded_version} would be a *downgrade*. This command doesn't allow it!");
}
Ok(version_regex.replace(gradle_properties, format!("${{field}}{}", upgraded_version)))
}
Expand Down Expand Up @@ -189,9 +187,7 @@ mod tests {
assert_eq!("smithy.rs.runtime.crate.stable.version=1.0.3", updated);
}

// ignored: we are temporarily removing this safeguard
#[test]
#[ignore]
fn downgrading_stable_crate_should_be_caught_as_err() {
let gradle_properties = "smithy.rs.runtime.crate.stable.version=1.0.2";
let version = semver::Version::new(1, 0, 1);
Expand All @@ -201,9 +197,7 @@ mod tests {
assert!(format!("{:?}", result).contains("downgrade"));
}

// ignored: we are temporarily removing this safeguard
#[test]
#[ignore]
fn downgrading_unstable_crate_should_be_caught_as_err() {
let gradle_properties = "smithy.rs.runtime.crate.unstable.version=0.57.1";
let version = semver::Version::new(0, 57, 0);
Expand Down

0 comments on commit ef1e37d

Please sign in to comment.