Properly adhere to Flow spec when converting flows #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
flow-publisher-httpclient
branch
from
42aa0a6 to
026d1bd
Compare
hpmellema
approved these changes
Feb 3, 2025
To map the JavaHttpClient's Flow.Publisher<List<ByteBuffer>> to our Flow.Publisher<ByteBuffer> we have to buffer byte buffers until downstream subscribers request them. We were previously just calling onNext with each individual ByteBuffer for as many buffers as we were handed by the client's publisher. In addition to now queueing these byte buffers when necessary, this commit also adds a dedicated DataStream for the JavaHttpClientTransport to avoid a bunch of intermediate conversions we were doing previously to convert the publisher to a ByteBuffer or to an InputStream. I added some basic test cases and also tested manually calling some services, which is how I discovered we needed to update system properties for the client statically too.
mtdowling
force-pushed
the
flow-publisher-httpclient
branch
from
026d1bd to
34995db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To map the JavaHttpClient's Flow.Publisher<List> to our Flow.Publisher we have to buffer byte buffers until downstream subscribers request them. We were previously just calling onNext with each individual ByteBuffer for as many buffers as we were handed by the client's publisher.
In addition to now queueing these byte buffers when necessary, this commit also adds a dedicated DataStream for the JavaHttpClientTransport to avoid a bunch of intermediate conversions we were doing previously to convert the publisher to a ByteBuffer or to an InputStream.
I added some basic test cases and also tested manually calling some services, which is how I discovered we needed to update system properties for the client statically too.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.