Use consumers for serde state management #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of the last commit. The goal there was to consolidate the logic to serialize a structure, but it ended up making struct serialization different from list and map, and it also introduced the need to manage struct state to ensure they're closed. By using only the consumer based API, there is a clear hook for before, during, and after that removes the need for state management. It also does not have any measurable performance impact to use the consumer API. Another benefit is that now StructSerializer can be a FunctionalInterface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of the last commit. The goal there was to consolidate the logic to serialize a structure, but it ended up making struct serialization different from list and map, and it also introduced the need to manage struct state to ensure they're closed. By using only the consumer based API, there is a clear hook for before, during, and after that removes the need for state management. It also does not have any measurable performance impact to use the consumer API. Another benefit is that now StructSerializer can be a FunctionalInterface.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.