Serialize documents as document w/ separate serde #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
Apr 10, 2024
hpmellema
approved these changes
Apr 10, 2024
mtdowling
force-pushed
the
simplify-list-serializer
branch
from
90e6149 to
d108ee0
Compare
Documents are now serialized as a document when serialized through a ShapeSerializer. The contents and inner data model contained within a document can be accessed using Document#serializeContents. This allows ShapeSerializer to receive documents as just documents and the schema of a document matches the data model type written to the serializer. It also allows serializers to, if they care, access the contents of the document. This change makes documents more principled and paves the way towards implementing validation without lots of special casing.
mtdowling
force-pushed
the
document-content-separation
branch
from
a66b036 to
ffbbf54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents are now serialized as a document when serialized through a ShapeSerializer. The contents and inner data model contained within a document can be accessed using Document#serializeContents. This allows ShapeSerializer to receive documents as just documents and the schema of a document matches the data model type written to the serializer. It also allows serializers to, if they care, access the contents of the document. This change makes documents more principled and paves the way towards implementing validation without lots of special casing.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.