Speedier gptmd again #2448
Open
Speedier gptmd again #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 93.89% 93.90%
=======================================
Files 146 146
Lines 22206 22218 +12
Branches 3059 3061 +2
=======================================
+ Hits 20851 20863 +12
Misses 906 906
Partials 449 449
|
eliminate unnecessary lock
trishorts
requested review from
nbollis,
Alexander-Sol,
pcruzparri,
zhuoxinshi and
RayMSMS
Alexander-Sol
requested changes
Jan 31, 2025
| @@ -76,6 +75,7 @@ protected override MetaMorpheusEngineResults RunSpecific() | |||
| } | |||
| Parallel.ForEach(Partitioner.Create(0, psms.Count), new ParallelOptions() { MaxDegreeOfParallelism = maxThreadsPerFile }, (range) => | |||
| { | |||
| var modDict = new ConcurrentDictionary<string, ConcurrentBag<Tuple<int, Modification>>>(); | |||
There was a problem hiding this comment.
This doesn't need to be concurrent, as it is created inside the parallel loop, i.e., one per thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.