Adjustments & fixes enabling ZooKeeper DIGEST-MD5 authentication #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztzg
changed the title
|
Hi @smiley22, Any interest in this patch? Cheers, -D |
kaleyroy
added a commit
to kaleyroy/S22.Sasl
that referenced
this pull request
May 8, 2020
1. Support netcore (Upgrade netfx45 to netstandard2) 2. Removed System.Configuration dependency (Netfx legacy) 3. Removed RIPEMD-160 algorithm (Not supported in netcore) 4. Fixed DIGEST-MD5 issue (Please refer to smiley22#3) 5. Excluded /Tests folder from project (For building only)
Great! You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @smiley22,
I have recently opened ewhauser/zookeeper#38 (comment) which adds initial SASL support to @ewhauser's pure .NET ZooKeeper client.
I used your implementation of
DIGEST-MD5to test it, and encountered a few interoperability issues which are fixed by the attached patches.Would you be willing to pull them?
On a related note, it would be great to have
GSSAPIsupport. I have found dotnet/Kerberos.NET#9, which is very interesting and promising, but still seems to be missing some pieces:There is also the possibility of using the MIT Kerberos implementation, for which https://github.com/SIGAN/gssapi already contains P/Invoke stubs. (I don't think it is complete enough for SASL support, but it should be possible to add the missing APIs.)
What do you think?