Allow warnings without an associated fence #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because when running as a git commit hook we frequently run into
issues that we want to report to the user but do not want to fail the
build, which are not associated with a specific build.
For example:
so that the incremental check on commits (e.g. large merges) does
not run for multiple minutes. This leaves open the option to opt into
a full check without blocking commits.
When the incremental check would exceed the maximum check limit, we
want to warn the user that the check is not happening, but not exit
with 1, as it would fail precommit hooks.
do not perform checks for the same reason as above
git in source or fence files, we skip validation. We want to warn
users about this because they may be running the program manually and
not running it over the set of files they think they are running it
over.