Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'revert inititaliz() to original. get_device_uuid_bytes is now private' #15

Merged
merged 1 commit into from
Nov 4, 2024
Merged

'revert inititaliz() to original. get_device_uuid_bytes is now private' #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/runtime/safe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ use uuid::Uuid;

/// Initialize the HIP runtime.
///
/// This function must be called before any other HIP functions.
/// Most HIP APIs implicitly initialize the HIP runtime.
/// This API provides control over the timing of the initialization.
///
/// # Returns
/// * `Result<()>` - Success or error status
Expand All @@ -17,11 +18,10 @@ use uuid::Uuid;
/// * The runtime fails to initialize
/// * The runtime is already initialized
pub fn initialize() -> Result<()> {
std::panic::catch_unwind(|| unsafe {
unsafe {
let code = sys::hipInit(0);
((), code).to_result()
})
.unwrap_or_else(|_| Err(HipError::from_kind(HipErrorKind::InvalidValue))) // Map panic to InvalidValue error
}
}

/// Get the number of available HIP devices.
Expand Down Expand Up @@ -202,7 +202,7 @@ pub fn get_device_name(device: Device) -> Result<String> {
/// * The device is invalid
/// * The runtime is not initialized
/// * There was an error retrieving the UUID
pub fn get_device_uuid_bytes(device: Device) -> Result<[i8; 16]> {
fn get_device_uuid_bytes(device: Device) -> Result<[i8; 16]> {
let mut hip_bytes = sys::hipUUID_t { bytes: [0; 16] };
unsafe {
let code = sys::hipDeviceGetUuid(&mut hip_bytes, device.id);
Expand Down