Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for discontinuous tecplot output #355

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

A-CGray
Copy link
Contributor

@A-CGray A-CGray commented Jan 29, 2025

  1. Modifies f5totec to take a --discontinuous command line argument, in which case nodes are duplicated so that element data is plotted as it is written out by TACS, rather than averaging values at nodes which leads to unphysical looking results for shells and beams etc. Some examples are shown below.
  2. Add discontinuous option to f5convert helper script
  3. Ran clang format on f5totec and f5tovtk
  4. Add f5totec and f5tovtk to clang format checks run on PRs

image

image

image

image

@A-CGray A-CGray requested a review from timryanb January 29, 2025 02:40
@A-CGray A-CGray marked this pull request as draft January 31, 2025 15:17
@timryanb
Copy link
Collaborator

For the discontinuous mode, it looks like some of the element values are getting assigned to the wrong elements. I managed to reproduce the issue on a tacs example case. The error appears to have to do with the number of procs used to run the model when the f5 file is generated. Heres what the discrete output looks like when running the example in serial (i.e. mpirun -np 1 python ibeam_example.py):
image (7)

And heres what it looks like when running on 8 procs (i.e. mpirun -np 8 python ibeam_example.py):
image (8)

@A-CGray
Copy link
Contributor Author

A-CGray commented Feb 21, 2025

I can reproduce this effect (below with mpiexec -n 4) so not a clang vs gcc thing

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants