Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Jeff.ACU.remove_device safe for non-existant devices #38

Merged
merged 1 commit into from
May 5, 2023
Merged

Make Jeff.ACU.remove_device safe for non-existant devices #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/jeff/acu.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,16 @@ defmodule Jeff.ACU do
end

def handle_call({:remove_device, address}, _from, state) do
device = Bus.get_device(state, address)
# TODO: Change this return to :ok
# I'm not sure returning a device is needed, but this allows
# this function to be safe without changing a ton of internals
# by just creating a dummy device struct when it doesn't exist
# in the registry. The Bus.remove_device/2 call will be a noop
device =
if Bus.registered?(state, address),
do: Bus.get_device(state, address),
else: Device.new(address: address)

state = Bus.remove_device(state, address)
{:reply, device, state}
end
Expand Down