Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type directed traversal #43

Merged
merged 14 commits into from
Mar 16, 2020
Merged

Type directed traversal #43

merged 14 commits into from
Mar 16, 2020

Conversation

sakari
Copy link
Collaborator

@sakari sakari commented Mar 11, 2020

use reflection types to figure out types of non-object values when doing map/pmap

@sakari sakari requested a review from buttilda March 11, 2020 07:15
}
}

class GenObject extends fc.Arbitrary<any> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that this generator might be useful outside of tests... I at least have had to build oats types by hand before 😬 I believe there's one of those In v8 still

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it cannot be in the distributed package because that would require fast-check which would just feel wrong. So somebody would need to take the time to create a new package. Hopefully in a new repo

@sakari
Copy link
Collaborator Author

sakari commented Mar 16, 2020

then nested package structure causes issues with linked packages not being enough when the linked package has an unpublished version yarnpkg/yarn#2611

Copy link
Contributor

@buttilda buttilda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well from my tests.

I got a general understanding on the code here, but I figured we're better off merging this than keeping it behind me having time to read everything 😅

@sakari sakari merged commit e2f5aa5 into master Mar 16, 2020
@sakari sakari deleted the type-directed-traversal branch March 16, 2020 09:25
sakari added a commit that referenced this pull request Aug 25, 2021
sakari added a commit that referenced this pull request Aug 25, 2021
sakari added a commit that referenced this pull request Aug 25, 2021
sakari added a commit that referenced this pull request Aug 25, 2021
sakari pushed a commit that referenced this pull request Aug 25, 2021
sakari added a commit that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants