-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type directed traversal #43
Conversation
…atible because the type changes
} | ||
} | ||
|
||
class GenObject extends fc.Arbitrary<any> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that this generator might be useful outside of tests... I at least have had to build oats types by hand before 😬 I believe there's one of those In v8
still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it cannot be in the distributed package because that would require fast-check which would just feel wrong. So somebody would need to take the time to create a new package. Hopefully in a new repo
then nested package structure causes issues with linked packages not being enough when the linked package has an unpublished version yarnpkg/yarn#2611 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well from my tests.
I got a general understanding on the code here, but I figured we're better off merging this than keeping it behind me having time to read everything 😅
Update actions/setup-node action to v2
use reflection types to figure out types of non-object values when doing map/pmap