Fix/Remove check for non-mandatory params for choice sets #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes [#265 ]
This PR is ready for review.
Testing Plan
Manual testing with test_suite
Summary
Currently, the sdl_hmi calls the
RPCObserver.checkChoicefunction only when thecapabilitiesCheckdetermines that there is anUNSUPPORTED_RESOURCE. ThecheckChoiceremoves a choice object if it is missing the optionalsecondaryTextandtertiaryTextparameters(as it does in the issue example). It doesn't seem to be specifically related toSTATICimages being used in the sdl_hmi.This PR removes the check for the optional parameters to prevent the choice object being removed from the choiceSet.
CLA