Fix/double send of on language change and on systeminfo changed #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKalinich-Luxoft
suggested changes
Nov 15, 2019
| }.observes('SDL.SDLModel.data.hmiUILanguage'), | ||
| /** | ||
| * Method to set language for TTS and VR components with parameters sent | ||
| * from SDLCore to UIRPC | ||
| */ | ||
| onLanguageChangeTTSVR: function() { | ||
| if (!this.canNotifyOnLanguageChange("VR")) { |
There was a problem hiding this comment.
@YarikMamykin it can be done in a simpler way:
- Remove
.observesfrom function - Find the control bound to this value
- If it is a
Em.Selectyou can declarechangefunction inside of it and just callonLanguageChangeTTSVRfrom that callback
There was a problem hiding this comment.
@AKalinich-Luxoft , unfortunately it doesn't work. In such case selected value will be changed with latency.
For example if you choose FR-CA language and current language is EN-US, then notification will send updated language value = EN-US! After that you can choose another language and only then FR-CA language will be displayed.
There was a problem hiding this comment.
@YarikMamykin use this.selection in change and pass it as a parameter to onLanguageChangeTTSVR then
There was a problem hiding this comment.
@AKalinich-Luxoft , yes, this idea works well! Thanks for the tip!
Take a look at 51d3013
mked-luxoft
approved these changes
Nov 15, 2019
AKalinich-Luxoft
approved these changes
Nov 15, 2019
LuxoftAKutsan
approved these changes
Nov 15, 2019
jacobkeeler
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
This PR is ready for review.
Testing Plan
Manual testing by steps described in #256
Summary
There is known bug in old version of Ember.js (specifically 1.0, which is currently used) - observers of SelectView item are noticed twice per each event. That is why
OnLanguageChangedandOnSystemInfoChangednotifications come twice.Implemented simple mechanism of blocking second notifications sending.
CLA