move the failure to connect message until after shutdown state check

[ettec]

Reasoning behind the change:

From BCF-3112, we see this panic in the logs:

panic: Log in goroutine after TestTelemetryIngressClient_Send_HappyPath has completed: 2024-03-

The wsrpc client runs 'resetTransport' in a goroutine, the routine does check that the state of the client in not in shutdown before attempting to reconnect, however, whilst attempting to connect the state can be changed to shutdown if the client is 'closed' (ie by, in this case, the test exiting). Thus, if the createTransport call errors (as is likely in the test shutdown scenario) the client will attempt to log the connection error. The fix is straightforward and no risk -> move the log until after the existing state check, not logging the error in the case where the client is in 'shutdown' state seems sensible.

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube