Add "WaitForReady" method #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This couples with the non-blocking start so that subsequent calls can wait for the dial to finish.
jkongie
previously approved these changes
Mar 6, 2023
samsondav
commented
Mar 6, 2023
| @@ -74,8 +76,15 @@ func WithWriteTimeout(d time.Duration) DialOption { | |||
| }) | |||
| } | |||
|
|
|||
| func WithLogger(lggr logger.Logger) DialOption { | |||
There was a problem hiding this comment.
Actually might be preferable to just make it required.
There was a problem hiding this comment.
I'd prefer to not make backwards incompatible changes here
There was a problem hiding this comment.
The current change is backwards-compatible.
jkongie
reviewed
Mar 7, 2023
| @@ -454,7 +479,7 @@ func (ac *addrConn) resetTransport() { | |||
| ac.mu.Unlock() | |||
|
|
|||
| // Reconnection backoff time | |||
| log.Println("[wsrpc] attempting reconnection in", backoffFor) | |||
| ac.dopts.logger.Infof("attempting reconnection in %s", backoffFor) | |||
There was a problem hiding this comment.
Is it ok to use %s here? backoffFor is a time.Duration
There was a problem hiding this comment.
Yeah it will call .String() and print a human readable duration
There was a problem hiding this comment.
jkongie
reviewed
Mar 7, 2023
jkongie
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This couples with the non-blocking start so that subsequent calls can
wait for the dial to finish.