timelock: handle log processing shutdown and Listen shutdown #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MStreet3
commented
May 3, 2024
| @@ -154,16 +155,18 @@ func (tw *Worker) Listen() error { | |||
| select { | |||
| case <-ctxwc.Done(): | |||
| case <-processingDone: | |||
| cancel() | |||
There was a problem hiding this comment.
call cancel here to stop the scheduling routine
MStreet3
commented
May 3, 2024
| <-historyDone | ||
| <-newDone | ||
| <-schedulingDone | ||
| shutdownCtx, cancel := context.WithTimeout(context.Background(), time.Second*5) |
There was a problem hiding this comment.
create a new context as the previous one is either done or was canceled
MStreet3
commented
May 3, 2024
| done := make(chan struct{}) | ||
| var ( | ||
| done, newDone, oldDone = make(chan struct{}), make(chan struct{}), make(chan struct{}) | ||
| ctxwc, cancel = context.WithCancel(ctx) |
There was a problem hiding this comment.
create a child context we can cancel when both log channels are closed
MStreet3
commented
May 3, 2024
| if err := tw.handleLog(ctx, log); err != nil { | ||
| case log, open := <-newLog: | ||
| if !open { | ||
| close(newDone) |
There was a problem hiding this comment.
if newLog is closed, signal new logs are done and set the channel to nil so this branch never is selected again
fbac
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shuts down the log processing goroutine if both log channels are closed. If both log channels close, then the context is canceled which forces a shutdown.
This PR also cancels the scheduling goroutine in the event that the processing goroutine shuts down. Once the Listen method starts to shutdown the worker, it now waits for all goroutines to finish with only a five second grace period.