Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish image #21

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Add workflow to publish image #21

merged 4 commits into from
Dec 20, 2023

Conversation

calvwang9
Copy link
Collaborator

@calvwang9 calvwang9 commented Dec 18, 2023

Setting up CICD to deploy timelock-worker on the production testnet env

guide ref: https://www.notion.so/chainlink/Create-CI-Pipeline-to-Build-Push-Docker-image-9c1306e0f2c940e39d581b0968068018

@fbac
Copy link
Contributor

fbac commented Dec 19, 2023

Hey Calvin, is this workflow going to publish public or private images?

@calvwang9
Copy link
Collaborator Author

@fbac will be publishing to a private ECR repo, following this guide https://www.notion.so/chainlink/Mapping-End-to-end-App-Deployment-e92e381bddff4cb2a78191f15931b144

.github/workflows/publish.yml Show resolved Hide resolved
uses: actions/checkout@v4

- name: Build and push image
uses: smartcontractkit/.github/actions/cicd-build-publish-artifacts-go@25645c21796ebb5554693fcc0d312dc88330fbe0 # cicd-build-publish-artifacts-go@0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this github action public? It seems I can't find it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, was a private action so replaced with a manual workflow

Copy link
Contributor

@fbac fbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbac
Copy link
Contributor

fbac commented Dec 20, 2023

@calvwang9 The workflow looks good to me.
Only one nitpick: it's not possible to manually trigger a image publish (for example being able to trigger on workflow_dispatch) so you'd have to wait until the next tag. I guess you already accounted for this?

@calvwang9 calvwang9 merged commit a27ca51 into develop Dec 20, 2023
@calvwang9 calvwang9 deleted the feat/cicd-publish branch December 20, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants