fix: don't check the "done" state when processing a Cancelled event #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
chore-convert-operation-tests-into-unit-tests
to
develop
December 2, 2024 02:12
|
Got a merge conflict now that the other is merged. |
gustavogama-cll
force-pushed
the
fix-dont-check-done-state-when-processing-cancelled-event
branch
from
93ad248 to
8e580a6
Compare
Thanks. The conflict is now fixed. |
The RBACTimelock contract does not mark an operation as `done` when it's cancelled. So the `isDone(operationID)` check we had in the "Cancelled" event handler actually prevented the timelock worker service from properly removing the operation from the scheduler. This PR simply removes the `isDone()` check and adds an integration test to verify that we're properly de-scheduling the operation.
gustavogama-cll
force-pushed
the
fix-dont-check-done-state-when-processing-cancelled-event
branch
from
8e580a6 to
f74d80d
Compare
graham-chainlink
approved these changes
Dec 27, 2024
gustavogama-cll
deleted the
fix-dont-check-done-state-when-processing-cancelled-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RBACTimelock contract does not mark an operation as
donewhen it's cancelled. So theisDone(operationID)check we had in the "Cancelled" event handler actually prevented the timelock worker service from properly removing the operation from the scheduler.This PR simply removes the
isDone()check and adds an integration test to verify that we're properly de-scheduling the operation.(depends on PR #118)