chore: replace zerolog with zap #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
chore-convert-operation-tests-into-unit-tests
to
develop
December 2, 2024 02:12
ajaskolski
previously approved these changes
Dec 9, 2024
gustavogama-cll
dismissed
ajaskolski’s stale review
The merge-base changed after approval.
gustavogama-cll
force-pushed
the
chore-replace-zerolog-with-zap
branch
from
1e66e36 to
d276898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
zerologlogging library withzap, which seems to be favored by other deployment automation projects.Note: We should discuss before merging as there seems to be several projects within chainlink that have chosen zerolog over zap. Additionally, recent benchmarks indicate that zerolog performs better.
(depends on PR #118)