Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamSpec #93

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Add StreamSpec #93

merged 6 commits into from
Nov 6, 2024

Conversation

martin-cll
Copy link
Collaborator

Frontend changes corresponding to the backend change here: smartcontractkit/chainlink#15044. We want to make sure that the new Stream jobs are correctly displayed on the jobs page.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.51%. Comparing base (b940c8d) to head (711ecff).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/screens/Job/generateJobDefinition.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   87.58%   87.51%   -0.08%     
==========================================
  Files         247      249       +2     
  Lines        4503     4572      +69     
  Branches      781      751      -30     
==========================================
+ Hits         3944     4001      +57     
- Misses        537      569      +32     
+ Partials       22        2      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msuchacz-cll
msuchacz-cll previously approved these changes Nov 6, 2024
samsondav
samsondav previously approved these changes Nov 6, 2024
@msuchacz-cll msuchacz-cll dismissed stale reviews from samsondav and themself via 045d923 November 6, 2024 14:20
@chudilka1 chudilka1 self-requested a review November 6, 2024 14:25
@samsondav samsondav merged commit 7c02aca into main Nov 6, 2024
7 checks passed
@samsondav samsondav deleted the ml/update-gql branch November 6, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants