[DPA-1160]: fix(chainconfig): make adminAddr optional #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making admin address field on the chain config popup optional instead of required, now that we introduced APTOS support on the popup, APTOS does not require admin address. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
|
giogam
approved these changes
Oct 23, 2024
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 29, 2024
The new version of operator UI makes the admin address field in chain config popup optional. Context: smartcontractkit/operator-ui#91 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 29, 2024
The new version of operator UI makes the admin address field in chain config popup optional. Context: smartcontractkit/operator-ui#91 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 29, 2024
The new version of operator UI makes the admin address field in chain config popup optional. Context: smartcontractkit/operator-ui#91 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Oct 29, 2024
The new version of operator UI makes the admin address field in chain config popup optional. Context: smartcontractkit/operator-ui#91 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making admin address field on the chain config popup optional instead of required, now that we introduced APTOS support on the popup, APTOS does not require admin address.
No changes to the backend required as it happily accepts empty string as a valid value.
I did a quick investigation on what happens if admin address is empty when passed into CLO & JD, looks like the field just get passed along, so if we dont provide a value, nothing happens. It jus shows empty value when user looks it up from the API.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
Steps to Test
yarn && yarn setupyarn startChecklist
If this PR creates changes to the operator-ui itself, rather than tests, pipeline changes, etc. Then please create a changeset so that a new release is created, and the changelog is updated. See: https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md#what-is-a-changeset