dynamic config for legacy vs. TOML #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
dynamic-config
branch
from
6ea2577 to
49a0ba1
Compare
samsondav
previously approved these changes
Nov 30, 2022
|
Updated with syntax highlighting and expansion panels: |
jkongie
approved these changes
Dec 1, 2022
samsondav
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the config screen to be more user friendly and dynamic with legacy vs. TOML.
Removed the
(legacy)suffix from ENV, let the error speak for itself when using TOML:When legacy config is in use, show only the dumped TOML, with an alternative title:
