[BCFR-963] - Remove Nonce Manual Override setting from UI

smartcontractkit · Nov 5, 2024 · f0865ab · f0865ab
1 parent cb39b89
commit f0865ab
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 36 deletions.
diff --git a/.changeset/friendly-cooks-exercise.md b/.changeset/friendly-cooks-exercise.md
@@ -0,0 +1,5 @@
+---
+'@smartcontractkit/operator-ui': patch
+---
+
+remove Next Nonce Manual Override UI setting as it is no longer connected to any backend functionality. This reduces UI complexity and avoids confussions.
diff --git a/@types/core/store/models.d.ts b/@types/core/store/models.d.ts
@@ -59,7 +59,6 @@ declare module 'core/store/models' {
   export interface EVMKeysChainRequest {
     address: string
     evmChainID: string
-    nextNonce: ?integer
     abandon: ?boolean
     enabled: ?boolean
   }
@@ -91,7 +90,6 @@ declare module 'core/store/models' {
     evmChainID: string
     address: string
     disabled: boolean
-    nonce: integer
   }
 
   // We really need to change the API for this. It not only returns levels but

diff --git a/src/api/v2/evmKeys.ts b/src/api/v2/evmKeys.ts
@@ -13,9 +13,6 @@ export class EVMKeys {
 
     query.append('address', request.address)
     query.append('evmChainID', request.evmChainID)
-    if (request.nextNonce !== null) {
-      query.append('nextNonce', request.nextNonce)
-    }
     if (request.abandon !== null) {
       query.append('abandon', String(request.abandon))
     }

diff --git a/src/screens/KeyManagement/EVMAccountRow.tsx b/src/screens/KeyManagement/EVMAccountRow.tsx
@@ -6,7 +6,6 @@ import TableRow from '@material-ui/core/TableRow'
 import Typography from '@material-ui/core/Typography'
 import Dialog from '@material-ui/core/Dialog'
 import Grid from '@material-ui/core/Grid'
-import TextField from '@material-ui/core/TextField'
 import Checkbox from '@material-ui/core/Checkbox'
 import FormGroup from '@material-ui/core/FormGroup'
 import FormControlLabel from '@material-ui/core/FormControlLabel'
@@ -95,20 +94,17 @@ interface Props {
 function apiCall({
   evmChainID,
   address,
-  nextNonce,
   abandon,
   enabled,
 }: {
   evmChainID: string
   address: string
-  nextNonce: bigint | null
   abandon: boolean
   enabled: boolean
 }): Promise<ApiResponse<EVMKey>> {
   const definition: EVMKeysChainRequest = {
     evmChainID,
     address,
-    nextNonce,
     abandon,
     enabled,
   }
@@ -126,22 +122,17 @@ const UnstyledEVMAccountRow: React.FC<Props> = ({
 
   const [modalOpen, setModalOpen] = useState(false)
   const [enabled, setEnabled] = useState(!ethKey.isDisabled)
-  const [nextNonce, setNextNonce] = useState<bigint | null>(null)
   const [abandon, setAbandon] = useState(false)
 
   const onSubmit = (event: React.SyntheticEvent) => {
     event.preventDefault()
-    handleUpdate(nextNonce, abandon, enabled)
+    handleUpdate(abandon, enabled)
   }
 
   const handleEnabledCheckboxChange = () => {
     setEnabled(!enabled)
   }
 
-  const handleNextNonceFieldChange = (event: any) => {
-    setNextNonce(event.target.value)
-  }
-
   const handleAbandonCheckboxChange = () => {
     setAbandon(!abandon)
   }
@@ -150,19 +141,13 @@ const UnstyledEVMAccountRow: React.FC<Props> = ({
     setModalOpen(false)
     // reset state
     setAbandon(false)
-    setNextNonce(null)
     setEnabled(!ethKey.isDisabled)
   }
 
-  async function handleUpdate(
-    nextNonce: bigint | null,
-    abandon: boolean,
-    enabled: boolean,
-  ) {
+  async function handleUpdate(abandon: boolean, enabled: boolean) {
     apiCall({
       evmChainID: ethKey.chain.id,
       address: ethKey.address,
-      nextNonce,
       abandon,
       enabled,
     })
@@ -226,20 +211,6 @@ const UnstyledEVMAccountRow: React.FC<Props> = ({
                     label="Enabled"
                   />
                 </FormGroup>
-                <FormGroup>
-                  <FormControlLabel
-                    className={classes.infoText}
-                    color="secondary"
-                    control={
-                      <TextField
-                        name="nextNonceField"
-                        type="number"
-                        onChange={handleNextNonceFieldChange}
-                      />
-                    }
-                    label="Next nonce manual override (optional)"
-                  />
-                </FormGroup>
                 <FormGroup>
                   <FormControlLabel
                     className={classes.infoText}