Skip to content

Commit

Permalink
fix(chainconfig): make adminAddr optional
Browse files Browse the repository at this point in the history
Making admin address field on the chain config popup optional instead of required, now that we introduced APTOS support on the popup, APTOS does not require admin address.

JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1160
  • Loading branch information
graham-chainlink committed Oct 21, 2024
1 parent 352091e commit b0a636f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changeset/real-zoos-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@smartcontractkit/operator-ui': minor
---

chainconfg: make admin address optional
3 changes: 0 additions & 3 deletions src/components/Form/ChainConfigurationForm.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ describe('ChainConfigurationForm', () => {
expect(await findByTestId('accountAddr-helper-text')).toHaveTextContent(
'Required',
)
expect(await findByTestId('adminAddr-helper-text')).toHaveTextContent(
'Required',
)
})

it('validates OCR input', async () => {
Expand Down
3 changes: 1 addition & 2 deletions src/components/Form/ChainConfigurationForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const ValidationSchema = Yup.object().shape({
chainType: Yup.string().required('Required'),
accountAddr: Yup.string().required('Required'),
accountAddrPubKey: Yup.string().nullable(),
adminAddr: Yup.string().required('Required'),
adminAddr: Yup.string(),
ocr1Multiaddr: Yup.string()
.when(['ocr1Enabled', 'ocr1IsBootstrap'], {
is: (enabled: boolean, isBootstrap: boolean) => enabled && isBootstrap,
Expand Down Expand Up @@ -327,7 +327,6 @@ export const ChainConfigurationForm = withStyles(styles)(
id="adminAddr"
name="adminAddr"
label="Admin Address"
required
fullWidth
helperText="The address used for LINK payments"
FormHelperTextProps={{
Expand Down

0 comments on commit b0a636f

Please sign in to comment.