Zp/change ganache #51
Draft
+1,668
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeuslawyer
force-pushed
the
zp/change-ganache
branch
from
20b5b4d to
7959104
Compare
Update to handle 127.0.0.1 instead of localhost. squash
zeuslawyer
force-pushed
the
zp/change-ganache
branch
from
7959104 to
115f308
Compare
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
KuphJr
reviewed
Dec 21, 2023
| @@ -588,6 +588,8 @@ return Functions.encodeString(escape("$hello*world?")); | |||
| **_NOTE:_** The `simulateScript` function is a debugging tool and hence is not a perfect representation of the actual Chainlink oracle execution environment. Therefore, it is important to make a Functions request on a supported testnet blockchain before mainnet usage. | |||
|
|
|||
| ### Local Functions Testnet | |||
| > **Note** | |||
| > Anvil is required to use `localFunctionsTestnet`. Please refer to the [foundry book](https://book.getfoundry.sh) for Anvil [installation instructions](https://book.getfoundry.sh/getting-started/installation). | |||
There was a problem hiding this comment.
@zeuslawyer So there is no way to make this work without users installing Anvil manually first? If so, then IMO we should just keep using Ganache until we have a better solution. This is very inconvenient for devs and Ganache still works fine.
There was a problem hiding this comment.
inclined to agree @KuphJr !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.