Peregrine Data External Adapter Submission

[droconnel22]

Closes #ISSUE_NUMBER_GOES_HERE

Description

......

Changes

• High level
• changes that
• you made

Steps to Test

1. Steps
2. to
3. test

Quality Assurance

• If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
• If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
• If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
• The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
• This is related to a maximum of one Jira story or GitHub issue.
• Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
• All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

[changeset-bot]

🦋 Changeset detected

Latest commit: 481efb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@chainlink/peregrine-fund-admin-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mxiao-cll]

Need to run yarn as well as yarn test peregrine-fund-admin/test

[mmcallister-cll]

once changes are made, please run yarn changeset and select major from root external-adapters-js dir.

[mmcallister-cll]

isn't this supposed to include the assetId as a path param the end?

[droconnel22]

There are now API search query params, I just need to include the assetId as path a variable on the end. This is true for both end points.

i.e. https://www.myfoo.com/api/v1/nav/100, https://www.myfoo.com/api/v1/reserves/100
https://www.myfoo.com/api/v1/reserves/{assetId}

[droconnel22]

I think i see the suggestion now will update with param injected into the endpoint string for the prepareRequest

[droconnel22]

once changes are made, please run yarn changeset and select major from root external-adapters-js dir.

this has now been run and commited in latest for this PR.

[droconnel22]

once changes are made, please run yarn changeset and select major from root external-adapters-js dir.

this has been run.

[droconnel22]

what is the correct way to run test in my directory? I tried yarn test, etc.

[mxiao-cll]

what is the correct way to run test in my directory? I tried yarn test, etc.

yarn test peregrine-fund-admin/test

in root

[droconnel22]

Need to run yarn as well as yarn test peregrine-fund-admin/test

Thank you I have now pushed the latest commit with 2 passing integration tests, at least locally passing. Please see if test pass as well.

[mxiao-cll]

Looks like you need to run yarn again

[mxiao-cll]

I also didn't see you latest commit

[droconnel22]

`

PASS packages/sources/peregrine-fund-admin/test/integration/adapter.test.ts

Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 2 passed, 2 total
Time: 2.561 s, estimated 3 s`

Please confirm running the integration tests pass as expected.

[mxiao-cll]

The values seems to be lost?

[mmcallister-cll]

Just need 1 changeset for the PR, please mark it major instead of patch

[mmcallister-cll]

might be what @mxiao-cll is mentioning below, but should there be default URLs here as there were in the original commit?

[mmcallister-cll]

you can get rid of the comments in this object

[mmcallister-cll]

here too please

[mmcallister-cll]

and here

[mmcallister-cll]

this is still missing the assetId, isn't it?

[mmcallister-cll]

I didn't follow the earlier discussion very closely but I think what you might be looking for here is something like the following:

add to nav inputParameters

    trancheSelector: {
      required: true,
      type: 'string',
      options: ['equityNav', 'seniorNAV', 'juniorNav'],
      description: 'The tranche to use as result',
    },

then here

result: Number(response.data[param.trancheSelector])

plus necessary validation/verification where appropriate

[mmcallister-cll]

Please run end to end manual tests as well on the package.
You'll need to set the necessary env vars (API_KEY, any endpoint overrides)
Then from external-adapters-js/packages/sources/peregrine-fund-admin run

> yarn build; yarn start

and request against your local EA with a curl like this (plus any additional params you add)

curl --location 'localhost:8080' \
--header 'Content-Type: application/json' \
--data '{
  "data": {
    "endpoint": "globalmarketcap",
    "assetId": "100"
  }
}'

hope this will help with the e2e debugging 🙏

[mmcallister-cll]

also I'm curious why this senior NAV is capitalized while junior and equity use Nav?