Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token and vault param in multichainAddress #3578

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add token and vault param in multichainAddress #3578

merged 1 commit into from
Nov 22, 2024

Conversation

mxiao-cll
Copy link
Contributor

Closes #ISSUE_NUMBER_GOES_HERE

Description

We need to query native gas balance for Lorenzo as well

Changes

Build it in por-address-list with additional params, no impact to existing functionality

Steps to Test

{
    "data": {
        "result": [
            {
                "chainId": "56",
                "contractAddress": "0x7130d2A12B9BCbFAe4f2634d864A1Ee1Ce3Ead9c",
                "wallets": [
                    "0xdE2BA910eBDCC53FC8a11dcD51aDe24E3eD5c3fC",
                    "0x70451b1AF665F490df5aC86c15F5162a383A594B"
                ]
            }
        ]
    },
    "statusCode": 200,
    "result": null,
    "timestamps": {
        "providerDataRequestedUnixMs": 1732288426190,
        "providerDataReceivedUnixMs": 1732288427405
    },
    "meta": {
        "adapterName": "POR_ADDRESS_LIST",
        "metrics": {
            "feedId": "{\"contractAddress\":\"0xb7c0817dd23de89e4204502dd2c2ef7f57d3a3b8\",\"contractAddressNetwork\":\"binance\",\"type\":\"tokens\",\"vaultPlaceHolder\":\"0x0000000000000000000000000000000000000001\",\"confirmations\":0,\"batchSize\":10}"
        }
    }
}
{
    "data": {
        "result": [
            {
                "address": "0xb8119F2ccfA504735c14D381cf888d1D267dbe43",
                "network": "b2",
                "chainId": "223"
            }
        ]
    },
    "statusCode": 200,
    "result": null,
    "timestamps": {
        "providerDataRequestedUnixMs": 1732288450036,
        "providerDataReceivedUnixMs": 1732288450884
    },
    "meta": {
        "adapterName": "POR_ADDRESS_LIST",
        "metrics": {
            "feedId": "{\"contractAddress\":\"0xb7c0817dd23de89e4204502dd2c2ef7f57d3a3b8\",\"contractAddressNetwork\":\"binance\",\"type\":\"vault\",\"vaultPlaceHolder\":\"0x0000000000000000000000000000000000000001\",\"confirmations\":0,\"batchSize\":10}"
        }
    }
}

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 573741b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chainlink/por-address-list-adapter Patch
@chainlink/proof-of-reserves-adapter Patch
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxiao-cll mxiao-cll merged commit 6e83b36 into main Nov 22, 2024
8 checks passed
@mxiao-cll mxiao-cll deleted the por branch November 22, 2024 15:59
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants