Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/DF-20745 proof of reserves token balance #3573

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Nov 20, 2024

Closes #DF-20745

Description

Adding token balance EA as an indexer to proof-of-reserves composite

Changes

  • Updated indexer list
  • Updated unique processors for expected inputs and outputs from protocol and indexer steps

Steps to Test

  1. yarn test proof-of-reserves
  2. sanity test using solv payload

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested a review from a team November 20, 2024 06:54
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 3e6eb0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@chainlink/proof-of-reserves-adapter Minor
@chainlink/renvm-address-set-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mxiao-cll
mxiao-cll previously approved these changes Nov 20, 2024
@mxiao-cll mxiao-cll merged commit 009020f into main Nov 20, 2024
8 checks passed
@mxiao-cll mxiao-cll deleted the feat/DF-20745-proof-of-reserves-token-balance branch November 20, 2024 21:05
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants